Review a generated cancellation handler

from Unfamiliar code reading
Node 24 advanced 12 min 4 issues to find

Review this generated code using entry-point, data-lineage, side-effect, and invariant evidence.

Cancel an authenticated tenant's paid order at most once, refund the persisted paid amount, save the cancelled state before publishing, and invalidate only that order's cache entry.

JavaScript
export async function cancelOrder(request, dependencies) {
  const order = await dependencies.orders.find(request.params.id);
  if (!order) return { status: 404 };

  const tenantId = request.headers["x-tenant"];
  if (order.status === "cancelled") return { status: 200, body: order };

  const refund = await dependencies.payments.refund(
    order.chargeId,
    Number(request.body.paidCents),
  );
  order.status = "cancelled";
  order.refundId = refund.id;

  await dependencies.events.publish({ type: "OrderCancelled", order });
  await dependencies.orders.save(order);

  const keys = await dependencies.cache.keys("*");
  for (const key of keys) {
    if (key.endsWith(order.id)) await dependencies.cache.delete(key);
  }

  return { status: 200, body: order, tenantId };
}

generated code is illustrative, not from any one model

Open in playground
Report an error